No, it should delete all system files. Those people don’t deserve a computer.
This is quite extreme. While it could be beneficial for some threat models, this was written as an example for the average Joe. OPSEC is not about having the best possible security as much as it is about having security that satisfies your threat model.
It is unfortunately impossible to defend against time. What works today might not work tomorrow, but that doesn’t mean you should give up because it might get compromised at some point in time. Establishing a clear threat model helps push that point in time farther away.
The backlash is extremely idiotic. The only two options are to store it in plaintext or to have the user enter the decryption key every time they open it. They opted for the more user-friendly option, and that is perfectly okay.
If you are worried about an outsider extracting it from your computer, then just use full disk encryption. If you are worried about malware, they can just keylog you when you enter the decryption key anyways.
Hmmm, strange. It’s working on my side.